search

Roave / SecurityAdvisories

:closed_lock_with_key: Security advisories as a simple composer exclusion list, updated daily
MIT License
2.7k stars 105 forks source link

Sort constraints to prevent useless diffs #40

Closed Ocramius closed 6 years ago

Ocramius commented 6 years ago

Commits like https://github.com/Roave/SecurityAdvisories/commit/a88d5f2e09a349e2d2f1dcde218860ede463a4f1 are quite frequent, and caused by different globbing/sorting of configurations, upgrades in components that do the YAML parsing and so on.

Basic sorting (can be very simple) of the constraints would prevent this in future.

I think @stof reported this previously.

Jean85 commented 6 years ago

I was confused at first, but maybe we should specify that this issue is related to https://github.com/Roave/SecurityAdvisoriesBuilder, right?

Ocramius commented 6 years ago

Groan, yes, my mistake :|

Ocramius commented 6 years ago

As per https://github.com/Roave/SecurityAdvisories/commit/f793fe6ff54acabd9bc9f76f4a9ad3c89a68c789 - this is now fixed. Thanks @Jean85!

Ocramius commented 6 years ago

Handled in https://github.com/Roave/SecurityAdvisoriesBuilder/pull/5