Closed internalsystemerror closed 1 year ago
These psalm errors don't show up locally, and I can fix all but 1, which gives an error locally OR on CI, but I can't solve for both:
https://github.com/Roave/psr-container-doctrine/actions/runs/3664302981/jobs/6194637843#step:6:28
When fixed for CI, locally I get a warning about an invalid suppresion.
Maybe that should just be a Memcached::class
reference?
Done. I was trying to avoid importing memcached
as that's why the suppression was originally there. But it only needs importing into the test it's used.
Oh, and memcached isn't actually installed in CI, so the builds will fail :/
Wait... PHP 8.1 now fails installation? D:
Yeah, I've noticed now that memcached was disabled in .github/workflows/test.yml
waiting on a fix for https://github.com/php-memcached-dev/php-memcached/issues/477 ... Let me revert some stuff here and put back the original suppression ... It fails locally, but that might be my setup.
OK ... Try that, should be all green now.
This PR:
vimeo/psalm
to v5psalm/plugin-phpunit
to v0.18Closes: