Roave / psr-container-doctrine

Doctrine Factories for PSR-11 Containers
BSD 2-Clause "Simplified" License
95 stars 31 forks source link

Add doctrine/annotations:v2, doctrine/event-manager:v2 and doctrine/persistence:v3 support #95

Closed Slamdunk closed 1 year ago

Slamdunk commented 1 year ago

I've seen that https://github.com/Roave/psr-container-doctrine/pull/82 and https://github.com/Roave/psr-container-doctrine/pull/83 have been marked as https://github.com/Roave/psr-container-doctrine/labels/BC%20BREAK but it seems to me that this can be released in a new MINOR, so we can ease the upgrade path for users.

After that, doctrine/cache:v2 needs the work of @mrVrAlex in https://github.com/Roave/psr-container-doctrine/pull/72 and a new MAJOR

mrVrAlex commented 1 year ago

Good point. But anyway I still have a general questions: If we now have support ORM only from 2.14 version, where have both support for cache 1.13 || 2.0 like and both persistanse major versions, also ORM not required annotations package anymore (optional), then why these packages are locked here?)

Slamdunk commented 1 year ago

then why these packages are locked here?

Because we can only clean them up in a new MAJOR, while this PR is only intended for a new MINOR.

In your PR I would definitively throw out of the window any non-latest release :+1:

Ocramius commented 1 year ago

@Slamdunk if this doesn't change any inherited symbols, I'd be inclined to doing it in a minor release: WDYT?

Slamdunk commented 1 year ago

Yes please.