Rob-- / memoryjs

Read and write process memory in Node.js (Windows API functions exposed via Node bindings)
MIT License
632 stars 86 forks source link

Fixed Bug with sync readMemory #24

Closed p410n3 closed 6 years ago

p410n3 commented 6 years ago

the aruments are now either 3 or 4 and not 2 or 3 like before. The example1.js throw this error:

 memoryjs.readMemory(handle, address, dataType.toLowerCase(), callback);
             ^

TypeError: fourth argument must be a function
    at Object.readMemory (X:\Dokumente\p410n3.JS\node_modules\memoryjs\index.js:
64:14)
    at Object.<anonymous> (X:\Dokumente\p410n3.JS\node_modules\memoryjs\example1
.js:86:61)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3
p410n3 commented 6 years ago

Also added a fix for the findpattern, which had the same issue

p410n3 commented 6 years ago

Could you please take a look? I really just want the NPM package to be updated

Rob-- commented 6 years ago

Sorry for taking so long to look into this, and thanks for your contribution.