search

Rob-- / memoryjs

Read and write process memory in Node.js (Windows API functions exposed via Node bindings)
MIT License
632 stars 86 forks source link

Async findPattern doesn't execute the callback / built in datatypes give wrong values #28

Closed dnnyy closed 6 years ago

dnnyy commented 6 years ago

Yo! Really good library so far apart from one problem. Async findpattern is not working properly, it doesn't execute the callback, even if I change the arguments to 6 in index.js (if (arguments.length === 6)) - compile it new, it still does not work. No idea how to fix it since I'm not a cpp programmer, but the callback does not execute. Also when using the sync method, I noticed that when I used the build in types for example memoryjs.READ | memoryjs.SUBTRACT the wrong offset returns. However, when I use hexadecimals (0x1 | 0x2) it gives the correct offset.

Regards

dnnyy commented 6 years ago

Alright fixed it. Gonna make a pull request.