search

Rob--W / browser-action-jplib

Jetpack module to add a Browser action badge to the toolbar, using the chrome.browserAction syntax from Chromium
21 stars 9 forks source link

Icon does not render in Customize box #4

Closed tmiw closed 10 years ago

tmiw commented 10 years ago

Extension: https://github.com/tmiw/newsrdr-checker Firefox 25.0 on OSX 10.9.0.

Icon .png file does not render in the Customize dialog box after dragging button off of the toolbar. (This is required in order to pass Mozilla's full verification.) Button renders normally on toolbar, however.

Any ideas?

Rob--W commented 10 years ago

Verified in Firefox 25.0 on Linux. This library uses toolbarwidget, which uses the SDK's widget module.

When I copy-paste the example from the documentation (that uses a 16x16 icon), I observe another bug (not specific to this library): Only the top-left 8x8 corner of the icon is shown. A quick look on bugzilla gives https://bugzilla.mozilla.org/show_bug.cgi?id=755384.

Because the icon is not even recognizable in Add-ons using SDK modules, this issue ends at the bottom at my to-do list.

For reference, steps to reproduce bug 755384:

  1. Create an add-on using cfx init
  2. Put the code below in lib/main.js.
  3. Run the extension, using cfx run
  4. Open the customization dialog, drag the button/icon to the dialog.
  5. Observe that the icon is cut off.
require("sdk/widget").Widget({
  id: "mozilla-icon",
  label: "My Mozilla Widget",
  contentURL: "http://www.mozilla.org/favicon.ico"
});