search

Rob--W / browser-action-jplib

Jetpack module to add a Browser action badge to the toolbar, using the chrome.browserAction syntax from Chromium
21 stars 9 forks source link

Fix Icon's issues #9

Closed metrofun closed 10 years ago

metrofun commented 10 years ago

1) Correct browser action icon is not displayed in the toolbar palette (i.e. customisation mode). Because js is not executed there. Also default "default_icon.png" is not rendered, and is irrelevant (tested on OSX). My solution is to replace "default_icon.png" substring from "browserActionBadge.html" file with the correct one on the fly.

2) Image is not correctly centered inside button My workaround is to center image relatively to an html tag, not a button.

Rob--W commented 10 years ago

What Firefox version did you use for testing?

Your patch will also solve issue #4, thanks for contributing!

metrofun commented 10 years ago

XSS fixed. Tested on Firefox 26 (OSX & Windows 7) BTW thanks for the great time-saving lib!

Rob--W commented 10 years ago

Thanks for the patch! Looks OK in Firefox 25.0 (Linux) and 29.0 (Nightly on Windows).

Rob--W commented 10 years ago

@metrofun I've added another commit to resolve issue 7 and released a new tag: https://github.com/Rob--W/browser-action-jplib/releases/tag/v0.2.4