Rob--W / cookie-manager

Cookie Manager for Firefox (Desktop/Android), Chrome. Supports viewing and editing of cookies and private cookies.
Mozilla Public License 2.0
105 stars 24 forks source link

css doesn't play nicely with dark firefox themes #24

Closed Boruch-Baum closed 2 years ago

Boruch-Baum commented 5 years ago

On the main page for a site, the page renders correctly white text on black background, but the boxes for cookie content are white background, meaning the text is invisible.

On the 'new' tab, all text is white on white background.

Rob--W commented 5 years ago

I installed https://addons.mozilla.org/en-US/firefox/addon/native-dark/ , but don't see anything out of the ordinary.

Can you describe how I can reproduce the bad appearance? Please add screenshots too.

Boruch-Baum commented 5 years ago

Here's a screenshot, using the native-dark add-on that you chose, and disabling all other related add-ons:

screenshot_2019-01-16_17-14-50

I should say that my report was not based upon using that specific native-dark add-on, but it turns out not to matter, the issue results in the same problem. I've tried both 'night reader for firefox' and 'toggle website colors' to get white text on black background for the content of web pages, and those scenarios are the one's for which I submitted this bug report.

When you performed your test, was your desktop native theme, ie. GTK/QT themes outside of firefox, also dark themes?

Rob--W commented 5 years ago

Extensions cannot directly modify the CSS of other extensions. And themes generally apply to the browser UI only, not the content.

How exactly did you change the color of the content? Is it via about:preferences > General > Language and Appearance > Colors ?

Boruch-Baum commented 5 years ago

Well, for the screenshot that I posted there were no relevant add-ons enabled except for the one that you suggested. Otherwise, the only thing that I'm using that affects color are my GTK/QT themes. That'sfor the screenshot.

When I originally made the report, I was using an extension that changed the css colors of web pages, but like I said, I had that extension disabled when I prepared the screenshot.

In page about:preferences / colors, it is true that I do have the settings as white on black background, but I also have the over-ride setting to never use those colors when a website explicitly has its own colors. As I said above, the way I change content is by using one of the many extensions that do that. Here are a few:

https://addons.mozilla.org/en-US/firefox/addon/nightreader/?src=search

https://addons.mozilla.org/en-US/firefox/addon/darkreader/?src=search

https://addons.mozilla.org/en-US/firefox/addon/togglewebsitecolors/

Rob--W commented 2 years ago

I have added dark theme support in version 1.7. This depends on the color-scheme CSS feature that's only available in Firefox 96 and up (which is the current stable version of Firefox).