search

Rob--W / crxviewer

Add-on / web app to view the source code of Chrome / Firefox / Opera 15 extensions and zip files.
https://robwu.nl/crxviewer/
Mozilla Public License 2.0
1.43k stars 221 forks source link

1.4 update Something with regex is bad #121

Closed Dark3n89 closed 2 years ago

Dark3n89 commented 2 years ago

I restore previous version and all work again :)

Rob--W commented 2 years ago

Could you share more details? What is the issue with the latest version? Please include steps to reproduce the issue.

Dark3n89 commented 2 years ago

I spot error tonight, i dont check source code changes now. But icon never change to yellow now, cant be activated popup menu.

Rob--W commented 2 years ago

Sounds like issue #120. I cannot reproduce the issue with the latest version of the Chromium browser and crxviewer.

What browser version are you using? Which webpage are you visiting?

Dark3n89 commented 2 years ago

chrome version dont know, i lock and forever kill chrome update 2yr back.

Clasic ext links inside google store

Your version from 2019 work still fine.

Rob--W commented 2 years ago

You can see the version at chrome://version/

Note: using a very old browser version is not recommended. There have been dozens of discovered security vulnerabilities that harms your security/privacy/data when exploited.

Dark3n89 commented 2 years ago

Im in bed today 2AM ,, will check source code tomorrow. I no need feel fear from "old" 😅😂 using hardcore modded system.

I dont watch manifest but my idea is ver 2 and ver 3 who doing problem on old chrome versions. IDK will must check.

Dark3n89 commented 2 years ago

chrome version dont know, i lock and forever kill chrome update 2yr back.

Clasic ext links inside google store

Your version from 2019 work still fine.

I found problem in source code, i delete section "conditions": in manifest, bcs is wasted and all work again perfect in latest version.

localfossa commented 2 years ago

I am using chrome on 100.0.4896.88 (Official Build) (64-bit) (cohort: Stable) version and I can confirm that on that version it is not working.

Dark3n89 commented 2 years ago

I am using chrome on 100.0.4896.88 (Official Build) (64-bit) (cohort: Stable) version and I can confirm that on that version it is not working.

Temporary quick help.. Download old one, or use current but fixed by me http://leteckaposta.cz/940951869 simply extract folder anywhere (dont delete ) and drag folder to extension field in brovser ( chrome://extensions/ )

Rob--W commented 2 years ago

Could you share the exact steps (or a video) of the steps that you are following to encounter this issue? As mentioned before, it worked for me when I tested it.

I'll take another look at this issue in the weekend.

Dark3n89 commented 2 years ago

Could you share the exact steps (or a video) of the steps that you are following to encounter this issue? As mentioned before, it worked for me when I tested it.

I'll take another look at this issue in the weekend.

simply, extension dont detect market links, never show yellow bg ( active stat ) i delete multiple lines from manifest and all work again. ( i share here link with working one, current version )

localfossa commented 2 years ago

Could you share the exact steps (or a video) of the steps that you are following to encounter this issue? As mentioned before, it worked for me when I tested it.

I'll take another look at this issue in the weekend.

When I install it the first time, it is working, but it stops working when I restart Chrome or similar. I need to reinstall the extension or disable it and then enable it to make it work.

localfossa commented 2 years ago

Screenshot_34 These are errors that showing when I installed extension and put it into developer mode.

Rob--W commented 2 years ago

When I install it the first time, it is working, but it stops working when I restart Chrome or similar. I need to reinstall the extension or disable it and then enable it to make it work.

Restarting was indeed a crucial step in the reproduction steps. This issue is caused by the following Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1132684

I'll work on an update that uses a different implementation (i.e. registering the rules on install). This is a bit complicated because of the need to work around the following Chrome bugs too: https://bugs.chromium.org/p/chromium/issues/detail?id=388231 and https://bugs.chromium.org/p/chromium/issues/detail?id=264963.

Rob--W commented 2 years ago

Resolved in version 1.6.13. I have linked the release to #120 because it is the first report and the title was more obvious. (#120 and this issue #121 are duplicates of each other)