search

Rob--W / dont-track-me-google

Firefox and Chrome extensions to prevent Google from making links ugly.
MIT License
459 stars 26 forks source link

Open search links in new tabs #28

Closed HeavenVolkoff closed 6 years ago

HeavenVolkoff commented 6 years ago

This adds an option (disabled by default) that forces all links to be opened in a new tab. This is relevant to me because I use this extension alongside Google Container, and I thought it could be useful to other people.

Rob--W commented 6 years ago

Did you know that pressing ctrl while clicking, or clicking using the scrollwheel achieves the same effect? If you rely on the keyboard and/or mouse to open in a new tab, then you always have the choice to open in the current or new tab.

HeavenVolkoff commented 6 years ago

Yeah, I know... But it can be quite cumbersome when you need to do this on a dozen of links when google searching. Maybe a separate extension would be a better place to enable this functionality, but yours was easier for me to hack this behavior into for my specific use case. Fell free to reject this merge if you think this behavior doesn't align with this addon's concept. However I thought it could be a functionality that someone else would find useful.

Rob--W commented 6 years ago

But it can be quite cumbersome when you need to do this on a dozen of links when google searching.

I can of course not speak for everyone, but at least for me, it takes little effort to use the scrollwheel.

Maybe a separate extension would be a better place to enable this functionality, but yours was easier for me to hack this behavior into for my specific use case.

I think a separate extension is indeed more appropriate here. I am not keen on merging this PR, because that implies that I need to support forcing links in new tabs. This is not a problem in itself, but I would probably also need to keep updating the extension to not open certain links in new tabs (e.g. links to "#"), and I am not interested in that maintenance burden.

I hope you understand, and thanks for taking the time to write this PR in the first place.

HeavenVolkoff commented 6 years ago

I am not keen on merging this PR, because that implies that I need to support forcing links in new tabs. (...) I hope you understand, and thanks for taking the time to write this PR in the first place.

No worries. I will keep my fork up. Thank you for taking time to review it.