Rob--W / dont-track-me-google

Firefox and Chrome extensions to prevent Google from making links ugly.
MIT License
459 stars 26 forks source link

Link on Google Calendar is not immediately sanitized #37

Closed rmccu closed 3 years ago

rmccu commented 4 years ago

It looks like links in the GCal are not being modified to strip the google tracking.

Here is a screenshot showing the hover over the location: Screen Shot 2020-06-24 at 3 09 35 PM

And hovering over a body link: Screen Shot 2020-06-24 at 3 10 13 PM

Rob--W commented 4 years ago

I just checked, and Google Calender retrieves the source code (HTML) for the link directly from the server. Because my extension only rewrites links that are created in the browser, it doesn't immediately catch this. I can change the implementation, but that will add some overhead.

Note that as soon as you try to interact with the link (e.g. clicking or right-clicking on the link), the link is sanitized. Is this good enough for you?

rmccu commented 4 years ago

Ok, as long as it sanitizes it. I am fine. Thanks!