Rob--W / dont-track-me-google

Firefox and Chrome extensions to prevent Google from making links ugly.
MIT License
459 stars 26 forks source link

Presenter View in Google Slides doesn't load. #49

Closed BartBlaak closed 1 year ago

Rob--W commented 1 year ago

Reproduction steps:

  1. Open a presentation, e.g. https://docs.google.com/presentation/d/1vpcH6pyFIbzYqS8KvXNWNvwWbc0XvFFgKX0g9pjP6Hs/edit
  2. Click on the triangle next to the Slideshow button, and click on the "Presenter view" button.
  3. Google Docs should render the slides in full screen AND open a popup.
  4. Look at the popup's content.

Expected:

Actual:

More info:

Rob--W commented 1 year ago

This bug is happening because Docs calls window.open("about:blank", ...), and about:blank is considered cross-origin by https://github.com/Rob--W/dont-track-me-google/blob/abffd08f6e0d6eacd42b3ff0ccda1b6838788949/contentscript.js#L409.

Consequently, noreferrer is added, which implies noopener, which prevents Docs from writing content to the new popup window.

Rob--W commented 1 year ago

I have created a fix for the issue. I'll wait a few days to allow for further feedback, and then publish an update.