Rob--W / dont-track-me-google

Firefox and Chrome extensions to prevent Google from making links ugly.
MIT License
459 stars 26 forks source link

[userscript] errors in console: TrustedScript assignment #53

Open dnmTX opened 1 year ago

dnmTX commented 1 year ago

Hi Rob @Rob--W. I don't really know when it started happening but i see these errors in console and i'm not sure if the userscript is working as intended. I'm using the latest version of it as of 07-02-2023. Posting here screenshot from console.Anything else i can do on my end,just let me know. Thank you 👍 Capture

P.S. Just to note here. I do mask my User Agent(using Firefox UA,otherwise i'm on Chromium). Hopefully this is not what causing the errors.

Just in case,ping @ameshkov from the AdguardTeam as i'm not sure which is the problem here,the userscript or some settings in AG. disableGoogleTracking.js.txt

Rob--W commented 1 year ago

Please provide all necessary (but ideally minimal) details to reproduce this problem independently. At least:

And also: is this an AdGuard-specific issue?

dnmTX commented 1 year ago

browser and version (Chrome, but which version?)

Slimjet Version 39.0.2.0 (based on Chromium 111.0.5563.41) (Official Build) (64-bit)

which Google site to visit (ideally one that doesn't require a login)

When i search in Google fo something(unfortunatelly i'm logged in all the time) that shows pictures in the results,like: https://www.google.com/search?q=iphone+best+wallpapers See screenshtot 👇

what actions to take to trigger the error

looks like when pictures are involved,when there aren't any,no errors showing up in console,like: https://www.google.com/search?q=dont-track-me-google#ip=1

And also: is this an AdGuard-specific issue?

Let's wait for @ameshkov's input first before i go that road(if you don't mind). That's why i uploaded copy of my userscript if he want's to try to reproduce it.

Capture

ameshkov commented 1 year ago

@dnmTX definitely it's on AG side

dnmTX commented 1 year ago

@dnmTX definitely it's on AG side

Oh wow,ok then.... Do i need to open issue there(which repo) or.......?

ameshkov commented 1 year ago

@dnmTX no worries, I already did

dnmTX commented 1 year ago

Great and thanks for your help Andrey @ameshkov,it's allways appreciated here 👍 Rob @Rob--W thanks for your input and fast response and sorry to bother you with this. I just wasn't sure where the problem is(was) 👍 Closing......

Rob--W commented 1 year ago

For visibility, the issue was filed at https://github.com/AdguardTeam/CoreLibs/issues/1779

ameshkov commented 1 year ago

Hi all, we did some research on the issue and we'll probably won't fix it. The Tampermonkey's solution is relaxing CSP a little bit and I'd better avoid doing that: https://github.com/AdguardTeam/CoreLibs/issues/1779#issuecomment-1692036526

Also, there's the same issue with Violentmonkey so maybe you'd want to fix it on the userscript side anyway. There're several simple ways to avoid this error: one is to use a policy when setting script's content, the other one is ignoring frames like google.*/uviewer.

Rob--W commented 1 year ago

I'm re-opening this issue to consider something like https://github.com/AdguardTeam/CoreLibs/issues/1779#issuecomment-1692036526