search

Rob--W / open-in-browser

A browser extension that offers the ability to open files directly in the browser instead of downloading them.
Other
88 stars 16 forks source link

Add-on pop-ups without clicking download #14

Open bdcomp opened 6 years ago

bdcomp commented 6 years ago

The just released WE version of this great add-on opens several pop-ups without clicking download or any other interaction from me. It looks like some ads related urls.

openinbrowser

Open in Browser 2.0 Firefox 57 Kubuntu 17.10 64bit

Rob--W commented 6 years ago

This is because the server does not send a type. Normally Firefox will sniff the type and then either display the content inline, or download it.

To not have those dialogs, select the top option ("Open with Firefox (Choose other application") and then it is up to Firefox how to view/open it. You can choose to remember the choice to always do this in the future (and if you want otherwise reset the preference at the Preferences page).

This issue can be fixed automatically if #5 is implemented.

bdcomp commented 6 years ago

Thanks for the prompt reply. This workaround works, so far.

Although, #5 will great improve the out-of-the-box behavior.

bdcomp commented 6 years ago

Just wondering, isn't it possible (without #5) to preset this workaround on add-on installation?

Rob--W commented 6 years ago

The issue is that without a MIME type, the extension does not know whether a dialog should be shown. For your specific case I have found another work-around, which I will push with the next update.

Rob--W commented 6 years ago

I published 2.1 with the above fixes. Please try again without the preference and see if you still encounter unwanted dialogs while browsing.

bdcomp commented 6 years ago

The 2.1 version improved a lot the out-of-the-box experience - only 1 pop-up after hours of browsing. It's similar to the description's screenshot, just (1 kb) in the "which is" line.

Great work!

Rob--W commented 6 years ago

Do you recall the circumstances under which that had happened? If you do then I can investigate it and try and fine-tune the checks even more.