search

Rob--W / open-in-browser

A browser extension that offers the ability to open files directly in the browser instead of downloading them.
Other
88 stars 16 forks source link

Clone appearance on Windows and macOS #18

Closed Rob--W closed 6 years ago

Rob--W commented 6 years ago

The current dialog is styled to be near-identical to Linux's dialog. A friend said that it looks a bit different on Windows.

Need to look in multiple places, including: https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/toolkit/themes/windows/mozapps/downloads/unknownContentType.css https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/toolkit/themes/osx/mozapps/downloads/unknownContentType.css

Rob--W commented 6 years ago

@BjornRuytenberg While working on #21 I realized that it is not too difficult to achieve a pixel-identical dialog appearance, but also that there is little value in doing so. The UX is similar regardless of the pixel values.

Also the slight difference in appearance should hopefully make the "Open in Firefox (Choose other Application)" option less confusing. Because of technical constraints, it is not possible to open the file with an external application through an extension, so I have to show the built-in dialog box in order to allow the user to make a choice.

If there are specific UX concerns that need to be addressed, please create a new issue.

Rob--W commented 6 years ago

Another thing: The dialog of my extension is wider than the built-in one (whose width is defined here) because I show the full URL of the file, whereas Firefox only shows the protocol + domain.