Doesn't remember settings after closing firefox

Rob--W / open-in-browser

A browser extension that offers the ability to open files directly in the browser instead of downloading them.

Other

83 stars 15 forks source link

Doesn't remember settings after closing firefox #39

Closed ghost closed 5 years ago

ghost commented 6 years ago

Hello, thank you for this great addon!

I noticed that after I close browser all my settings and remembered actions are lost. How are they stored? Indexeddb, local storage or anything else?

I use CookieAutoDelete which clear cookies and localstorage but shouldn't touch extensions data.

Firefox 59

Rob--W commented 6 years ago

I use localStorage. The implementation is at https://github.com/Rob--W/open-in-browser/blob/master/extension/prefs.js

ghost commented 6 years ago

It seems both:

CookieAutoDelete -> Settings -> Localstorage cleanup
Firefox Preferences -> Privacy & Security -> History -> Clear history when Firefox closes -> Offline Website Data

Result in clearing this addon settings. I use dozens of addons but this one is first affected by those. I see you already have a plan to migrate to browser.storage so feel free to close this if you don't want this separate issue.

Rob--W commented 5 years ago

Fixed in 2.7.