Implement import and export functionality

Rob--W / open-in-browser

A browser extension that offers the ability to open files directly in the browser instead of downloading them.

Other

83 stars 15 forks source link

Implement import and export functionality #42

Closed Mathnerd314 closed 6 years ago

Mathnerd314 commented 6 years ago

Fixes #41.

Mathnerd314 commented 6 years ago

I added error display using window.alert, it seems to work OK. Not sure how to trigger a FileReader error event so I didn't test that part of the code.

Mathnerd314 commented 6 years ago

Any update on this?

Rob--W commented 6 years ago

Sorry for the late reply - I missed the previous notifications. The PR looks good to me.

To test the fr.onerror, you could try to select a file for which you don't have the permission to read it. I'm getting a cryptic "Node was not found" error when I do that, but that's better than silently ignoring the error without user feedback.

Thanks for the PR and the follow-up!