Rob--W / open-in-browser

A browser extension that offers the ability to open files directly in the browser instead of downloading them.
Other
83 stars 15 forks source link

Stopped working in Nightly #56

Open iwantmyfreetv opened 5 years ago

iwantmyfreetv commented 5 years ago

Steps to reproduce: Go to http://www.lvtvv.com/repo/ Click on zip Observe blank 150x400px (estimate) panel appear with nothing visible and nothing hidden accepting keyboard driven events (such as Enter)

Rob--W commented 5 years ago

Thanks for the report!

I tried on Linux in Firefox 68.0a1 build ID 20190326095147 (see about:support), but couldn't reproduce at the first try. Then I tried again and observed a small white dialog. After that I couldn't reproduce again.

When I did manage to reproduce the problem, the global browser console (Ctrl-Shift-J) showed the following errors:

TypeError: this.input.inputField is undefinedUrlbarEventBufferer.jsm:61:5
    UrlbarEventBufferer resource:///modules/UrlbarEventBufferer.jsm:61
    UrlbarInput resource:///modules/UrlbarInput.jsm:143
    get urlbar chrome://browser/content/browser.js:207
    <anonymous> chrome://browser/content/browser.js:192
    get resource://gre/modules/XPCOMUtils.jsm:129
    _setURLBarPlaceholder chrome://browser/content/browser.js:4139
    initPlaceHolder chrome://browser/content/browser.js:4072
    onDOMContentLoaded chrome://browser/content/browser.js:1426
    onDOMContentLoaded self-hosted:985

this._box is null browser-sidebar.js:328
    get isOpen chrome://browser/content/browser-sidebar.js:328
    get currentID chrome://browser/content/browser-sidebar.js:335
    onWindowOpen chrome://browser/content/parent/ext-menus.js:994
    handleEvent chrome://extensions/content/parent/ext-tabs-base.js:1592

TypeError: gURLBar is undefinedbrowser.js:1497:7
    onLoad chrome://browser/content/browser.js:1497
    onLoad self-hosted:985

When I did not manage to reproduce, I still saw some errors:

this._box is null browser-sidebar.js:328
    get isOpen chrome://browser/content/browser-sidebar.js:328
    get currentID chrome://browser/content/browser-sidebar.js:335
    onWindowOpen chrome://browser/content/parent/ext-menus.js:994
    handleEvent chrome://extensions/content/parent/ext-tabs-base.js:1592

editor is null UrlbarValueFormatter.jsm:297
    _formatSearchAlias resource:///modules/UrlbarValueFormatter.jsm:297
    update resource:///modules/UrlbarValueFormatter.jsm:59
    formatValue chrome://browser/content/urlbarBindings.xml:584
    onSecurityChange chrome://browser/content/browser.js:5176
    callListeners chrome://browser/content/tabbrowser.js:746
    _callProgressListeners chrome://browser/content/tabbrowser.js:759
    _callProgressListeners chrome://browser/content/tabbrowser.js:4822
    onSecurityChange chrome://browser/content/tabbrowser.js:5185
    _callProgressListeners resource://gre/modules/RemoteWebProgress.jsm:156
    receiveMessage resource://gre/modules/RemoteWebProgress.jsm:312

This most likely looks like a bug in Firefox. I'll investigate later and file a bug at https://bugzilla.mozilla.org/ if needed.

Rob--W commented 5 years ago

If you are able to consistently reproduce this bug, could you describe what steps you are following, and the version of Firefox Nightly that you are using?