search

RobCherry / docker-chromedriver

Docker container for creating ChromeDriver servers
99 stars 74 forks source link

Fixed extra CLI enviroment variable reference. #12

Closed Walt-H closed 6 years ago

Walt-H commented 6 years ago

Hey RobCherry!

When using your docker image, I stumbled upon this tiny bug when trying to see if my custom arguments were set:

root@004c3fd0d1ac:/# ps aux
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1  3.1  0.9  57440 19768 ?        Ss   11:34   0:00 /usr/bin/python /usr/local/bin/supervisord -c 
....
automat+    11  0.0  0.2 101620  5496 ?        Sl   11:35   0:00 /usr/local/bin/chromedriver --port=4444 --whitelisted-ips=127.0.0.1 --url-base= $(ENV_CHROMEDRIVER_EXTRA_ARGS)s

Since a $ was used in lieu of %, the text was printed literally, as opposed to dereferencing the environment variable.

Thanks again for all your hard work :)