RobCherry / docker-chromedriver

Docker container for creating ChromeDriver servers
99 stars 74 forks source link

arm support welcome #16

Closed Fohlen closed 6 years ago

Fohlen commented 6 years ago

Hey there @RobCherry I was thinking about offering cross-platform builds for arm. Since I am on OSX the toolchain is quite easy to set up (no QUEMU required). Would you like this to be supported? Would you mind pushing the images to the repository?

The aim here is to build a small aggregation tool that can work on my Raspberry Pi. That surely takes away a lot of hassle if it runs in a Docker container!

RobCherry commented 6 years ago

I would be all for integrating support for multiple architectures. That is not something I have attempting yet (using manifest-tool), and I am not sure if/how Docker Hub supports automatically building for those, but any contributions are welcome.

Fohlen commented 6 years ago

Thanks for coming back at me! After some research I do not think Docker provides multi-arch out of the box. Still, what can be done is:

I think for now I will likely just fork this repo and compile binaries myself, where needed. If we see there is a larger demand for people using ARM we might set up such a pipeline 👍 Thanks for the fast and positive reaction!

RobCherry commented 6 years ago

Sorry, didn't mean to close this.

Fohlen commented 6 years ago

Hey, I added a PR under #17