search

RobCoIndustries / pipboy

:beginner: Experimental pipboy Desktop app for Fallout 4
BSD 3-Clause "New" or "Revised" License
61 stars 7 forks source link

Localmap Fetch-Cycle is easily interrupted #23

Open kitten opened 8 years ago

kitten commented 8 years ago

The Localmap is updating itself by fetching a new localmap image when it received the one. This cycle is easily broken if the player is opening a menu, fast travelling, etc. Hence the command has to be sent at another point of the localmap component.

rgbkrk commented 8 years ago

Another annoyance is that with the current logic if the map is empty, it won't do an update which means that it won't fetch another.

luckydonald commented 8 years ago

this is really an issue. Starting the app on a second screen on the same machine is already a struggle (#22), and with that I have to restart it every time. Alt+tab out, restart, switch back to it, be quick enough to exit pause menu in time, etc.

rgbkrk commented 8 years ago

This behavior was much better before the introduction of React+Fluorine(+Redux). Something didn't transition well. Right now I'm getting up to speed on the tooling that was introduced then I'll tackle this tonight.

Poor workaround I've used: click About, then click Map again.

rgbkrk commented 8 years ago

It looks like @philplckthun has a branch for improving this, I'll assume he's going to squish this bug.

luckydonald commented 8 years ago

bump