search

RobDHess / Steerable-E3-GNN

E(3) Steerable Graph Neural Network
MIT License
111 stars 20 forks source link

Question About Missing Variable #4

Open amorehead opened 2 years ago

amorehead commented 2 years ago

Hello. First off, thank you all very much for releasing the source code to your great paper. I had a small question about where this node_attr variable, referenced below, comes from, as it does not appear to be defined anywhere else in the SEGNN model's code.

https://github.com/RobDHess/Steerable-E3-GNN/blob/eda3680c94e89ff1da546197d48ac12cbc722430/models/segnn/segnn.py#L95

Is this node_attr variable in fact coming from graph.node_attr?

RobDHess commented 2 years ago

Hi,

That seems to be an old variable name that was not properly updated. Since node attributes in our experiments are defined as the average of the edge attributes, an isolated node would not be assigned any node attributes. We therefore set it to zero. I believe this should be changed to node_attr_irreps.shape[-1], but I'll double check later today.