search

RobErskine / Craft-User-Manual

📚 Help Section Plugin for Craft CMS.
MIT License
85 stars 17 forks source link

Add hash tag based navigation for large list of menu items. #19

Closed sameerast closed 2 years ago

sameerast commented 4 years ago

When the user manual has a long length of the menu items and after scrolling all the way down, if the user clicked on any help menu item which is bottom the list. The page will be refreshed to the new help section but clicked menu item all the down(out of the viewpoint), there is no clue about where is the clicked item.

This code bit always keeps the clicked menu item on the viewpoint.

RobErskine commented 4 years ago

Hey @sameerast. Thanks so much for this PR. I was a little busy today and didn't get a chance to review this. I'll check it out tomorrow for sure though. Thanks again.

sameerast commented 4 years ago

Hi Rob, I addressed all the points were highlighted. Thank you for taking some time.

sameerast commented 4 years ago

@RobErskine did you get a chance to review the changes.

RobErskine commented 2 years ago

Might be over a year later but it's never to late for a merge 😅. Thanks for this @sameerast