RobHofmann / HomeAssistant-GreeClimateComponent

Custom Gree climate component written in Python3 for Home Assistant. Controls AC's supporting the Gree protocol.
GNU General Public License v3.0
318 stars 106 forks source link

v2.14 #188

Closed toughvj closed 4 months ago

toughvj commented 4 months ago

IMPORTANT! From this version, auto_light and auto_xfan must be set as input_boolean

Machaeon commented 4 months ago

The horizontal swing setting seems to have disappeared from the interface.

toughvj commented 4 months ago

no. it's not

stenvix commented 4 months ago
image image

This may be related to your code, but in 2.13 it disappeared as well

toughvj commented 4 months ago

have you set horizontal_swing: true ifconfig?

Machaeon commented 4 months ago

No, I haven't set it.

toughvj commented 4 months ago

So? Everything is in readme file

Machaeon commented 4 months ago

horizontal_swing: <OPTIONAL: boolean (true/false); this feature will enable horizontal swing on devices that have this functionality. This feature replaces presets in the UI UI allows to set the swing range. I do not want to replace UI Presets so I didn't set this option.

toughvj commented 4 months ago

I'm a little confused. You write that horizontal_swing doesn't work, but you don't actually use it. Do you mean that you are using the built-in presets and want them to appear in the selection list if you don't want to use horizontal_swing? Do you mean something else?

Machaeon commented 4 months ago

Well, yes, adding the horizontal_swing option to the config enables the horizontal swing settings in the UI card. I was confused by the words "This feature replaces presets in the UI" and didn't add it before. Is it just me, or did previous versions have a swing setting in the UI without adding this option?

toughvj commented 4 months ago

You're right, previous versions didn't require this option. I have now made one more change: if the horizontal_swing option is not set, the device in HA does not have a preset option, so it does not appear as an empty list in the UI.

RobHofmann commented 4 months ago

Tested! Works like a charm again. Thanks @toughvj :).