RobK / photobox-downloader

NodeJS app to download all photos from Photobox website
MIT License
12 stars 11 forks source link

Download stop when find a symbol (: , #@% etc...) #15

Open ObregonL opened 4 years ago

ObregonL commented 4 years ago

Hi guys hope you can help.

I start to receive the an error message:

image (5)

Normally due to finding symbols such as (: , #@% etc...). during the download. If any photo or folder name has a symbol, the download just stops. I need to find the folder or picture and delete any symbol and start the process from the beginning.

Could you please help. Thanks

ObregonL commented 4 years ago

Hi, Any chance to you have a look?

ObregonL commented 3 years ago

Hi. could you please help with this issue/

ObregonL commented 3 years ago

HI Support can you please help to sort this issue?

tharglet commented 3 years ago

Hi, rolling through as I was fixing another issue... but can't replicate this one. I can get it to fail at mkdir but can't replicate this exactly. Do you have an exact filename that was causing the issue?

(Looking at the source code it only takes \ out of folder names and not the bulk of illegal chars for file and folder names)

ObregonL commented 3 years ago

Thanks for your email

Exactly, this is what causes the problem when trying to download albums that include chars. However, since 2 weeks ago it is not performing any type of download even if it does not contain any type of chars, see below: [image: image.png] Could you please take a look?

On Wed, Nov 11, 2020 at 9:18 PM tharglet notifications@github.com wrote:

Hi, rolling through as I was fixing another issue... but can't replicate this one. I can get it to fail at mkdir but can't replicate this exactly. Do you have an exact filename that was causing the issue?

(Looking at the source code it only takes \ out of folder names and not the bulk of illegal chars for file and folder names)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RobK/photobox-downloader/issues/15#issuecomment-725666486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREMZ46MHGVCH2XLGPLLRVTSPL5R7ANCNFSM4RZM6B5Q .

--

Best Regards

Luis ObregonCS Support Administrator

[image: Sig logos.png]

M: +44 7715 068053 E: luis.obregon@photobox.com W: www.photobox.com

[image: https://www.facebook.com/PhotoBoxPBX] https://www.facebook.com/PhotoBoxPBX [image: https://www.linkedin.com/company/photobox/] https://www.linkedin.com/company/photobox/ [image: https://www.instagram.com/photoboxuk/] https://www.instagram.com/photoboxuk/ [image: https://www.pinterest.fr/PhotoBoxUK/] https://www.pinterest.fr/PhotoBoxUK/

Herbal House, 10 Back Hill, London EC1R 5EN, UK https://www.google.co.uk/maps/place/10+Back+Hill,+London+EC1R+5EN/@51.5225958,-0.1113031,17z/data=!3m1!4b1!4m5!3m4!1s0x48761b4efe8701cf:0xdafe4b4566564464!8m2!3d51.5225958!4d-0.1091144

Photobox is registered in England and Wales. Company No: 03906401 Registered Address: Herbal House, 10 Back Hill, London EC1R 5EN

--

*This message and any attachment are confidential and may be privileged or otherwise protected from disclosure. If you are not the intended recipient you must not copy this message or attachment or disclose the contents to any other person. For more information please contact:   *info@photobox.com mailto:info@photobox.com

PhotoBox Group, Herbal House, 10 Back Hill, London, EC1R 5EN

http://group.photobox.com http://group.photobox.com/

tharglet commented 3 years ago

The image failed to attach - can't see it on github. If it's stopped entirely, want to try downloading & installing this version, and see if the issue persists?

(For attaching the image, I'd suggest viewing the issue in Github and pasting the image into the reply box. I'd suggest obscuring any personal details in screenshots, if any are visible).

ObregonL commented 3 years ago

Good morning,

I keep getting the below error. Can you please check? error: message=Invalid URI "/assets/site_errors/logo-pbx-group.svg", stack=Error: Invalid URI "/assets/site_errors/logo-pbx-group.svg" at Request.init (C:\Users\luis.obregon\AppData\Roaming\npm\node_modules\photobox-downloader\node_modules\request\request.js:273:31) at new Request (C:\Users\luis.obregon\AppData\Roaming\npm\node_modules\photobox-downloader\node_modules\request\request.js:127:8) at request (C:\Users\luis.obregon\AppData\Roaming\npm\node_modules\photobox-downloader\node_modules\request\index.js:53:10) at C:\Users\luis.obregon\AppData\Roaming\npm\node_modules\photobox-downloader\node_modules\request\index.js:100:12

SiSniper commented 1 year ago

Agree get this error when trying to download files with \ in filename. seem to have thousands with 01\DSC01234.jpg style format and receive the following error message.

Starting to download all albums and photos to: C:\Users\xyz\Downloads\photobox-downloader-master\albums Processing album: nic [ ] Downloading 6 of 1241 (0%)node:events:491 throw er; // Unhandled 'error' event ^

Error: ENOENT: no such file or directory, open 'C:\Users\xyz\Downloads\photobox-downloader-master\albums\nic\03\DSC_9530.jpg' Emitted 'error' event on WriteStream instance at: at WriteStream.onerror (node:internal/streams/legacy:62:12) at WriteStream.emit (node:events:513:28) at emitErrorNT (node:internal/streams/destroy:151:8) at emitErrorCloseNT (node:internal/streams/destroy:116:3) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { errno: -4058, code: 'ENOENT', syscall: 'open', path: 'C:\Users\xyz\Downloads\photobox-downloader-master\albums\nic\03\DSC_9530.jpg' }

krinkuto11 commented 1 year ago

Agree get this error when trying to download files with \ in filename. seem to have thousands with 01\DSC01234.jpg style format and receive the following error message.

Starting to download all albums and photos to: C:\Users\xyz\Downloads\photobox-downloader-master\albums Processing album: nic [ ] Downloading 6 of 1241 (0%)node:events:491 throw er; // Unhandled 'error' event ^

Error: ENOENT: no such file or directory, open 'C:\Users\xyz\Downloads\photobox-downloader-master\albums\nic\03\DSC_9530.jpg' Emitted 'error' event on WriteStream instance at: at WriteStream.onerror (node:internal/streams/legacy:62:12) at WriteStream.emit (node:events:513:28) at emitErrorNT (node:internal/streams/destroy:151:8) at emitErrorCloseNT (node:internal/streams/destroy:116:3) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { errno: -4058, code: 'ENOENT', syscall: 'open', path: 'C:\Users\xyz\Downloads\photobox-downloader-master\albums\nic\03\DSC_9530.jpg' }

I fixed this in my fork. It's a bit of a rough patch but you may want to try it out.