RobK / photobox-downloader

NodeJS app to download all photos from Photobox website
MIT License
12 stars 11 forks source link

Error for Downloading #16

Closed craigmate closed 4 years ago

craigmate commented 4 years ago

HI I have tried running your program on both a raspberry pi and ubuntu VM and i keep receiving the below errors

Processing album: Hazlin /usr/local/lib/node_modules/photobox-downloader/lib/photobox.js:232 link = pageLink.replace('&page=2&', '&page=' + i + '&'); ^

TypeError: Cannot read property 'replace' of undefined at Request._callback (/usr/local/lib/node_modules/photobox-downloader/lib/photobox.js:232:31) at Request.self.callback (/usr/local/lib/node_modules/photobox-downloader/node_modules/request/request.js:185:22) at emitTwo (events.js:126:13) at Request.emit (events.js:214:7) at Request. (/usr/local/lib/node_modules/photobox-downloader/node_modules/request/request.js:1154:10) at emitOne (events.js:116:13) at Request.emit (events.js:211:7) at IncomingMessage. (/usr/local/lib/node_modules/photobox-downloader/node_modules/request/request.js:1076:12) at Object.onceWrapper (events.js:313:30) at emitNone (events.js:111:20)

Also when I installed it. I got some deprecation errors

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated har-validator@5.1.5: this library is no longer supported /usr/local/bin/pbdl -> /usr/local/lib/node_modules/photobox-downloader/photobox-dl.js

If anyone can point me in the right direction, that would be great.

PhilTee commented 4 years ago

I replaced all instances of http:// with https:// in photobox.js and downloads started working.

craigmate commented 4 years ago

Thanks for that, I changed all the settings to https and it worked. Cheers It probably should be in the photobox.js but thats for the owner to decide I guess.