Closed russellf9 closed 7 years ago
Thanks for the bug report. Git should have stripped the Windows style line endings on commit. I'll make a release this weekend from my Debian box to resolve the issue.
Cheers, Robert
Hi Robert
Thanks for the email, glad to be of help
Russell
On 1 Dec 2016, at 19:15, Robert Kehoe notifications@github.com wrote:
Thanks for the bug report. Git should have stripped the Windows style line endings on commit. I'll make a release this weekend from my Debian box to resolve the issue.
Cheers, Robert
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RobK/photobox-downloader/issues/5#issuecomment-264265617, or mute the thread https://github.com/notifications/unsubscribe-auth/AErzK8UWfPOS4RDUgt44Ev2EHgOEMWSuks5rDxzlgaJpZM4LAPdB.
Fixed with commit: https://github.com/RobK/photobox-downloader/commit/64b53befcf25e07671c18f9ef8d8f510c7f880dc
Have published updated version to npm repo as well (npm update -g photobox-downloader)
Thanks again for the report.
Running the
pbdl
script on OSX got the error:I did some research and this is caused by a JS file having DOS line breaks rather than Unix line breaks.
As a workaround I used dos2unix to fix the JS file:
Perhaps it would be beneficial to encode the file for Unix users?
I know VIM can do that converting - "\r\n" to "\n"
Thanks for the great tool - my photos are downloading now! - russellf9