seemingly broken themes in geany 1.23

[landroni]

I tested base16-geany with geany 1.23 and it looks like the themes are broken. Notice how much bold there is in the screenshot of https://github.com/landroni/gWidgets2-filter/blob/master/gWidgets2-filter.R .

Is this a known issue?

[landroni]

Let me elaborate. By default (the way, say, the base16-80s theme is distributed right now) the themes look kind of broken when used with *.R files: too much bold and italic, and the code is definitely unreadable. It certainly looked very different from the RStudio implementation of the Tomorrow-80s theme. (RStudio itself uses Ace as an editing platform.)

So after some manual fiddling I managed to tweak the base16-80s to resemble much more closely to that of RStudio (and for the code being more readable). Here's the patch that I came up with:

--- /home/geek/.config/geany/colorschemes/base16-eighties.dark.conf
+++ /home/geek/.config/geany/colorschemes/base16-eighties.dark-tweaked.conf
@@ -73,15 +74,15 @@
 keyword=#d27b53;;true;false
 # Person.rb = class, include, def, end, attr_accessor, etc
 # PHP = include_once(), if elseif else
-keyword_1=#cc99cc;;true;false
-keyword_2=#66cccc;;false;true
+keyword_1=#cc99cc;;false;false
+keyword_2=#d3d0c8;;false;false
 keyword_3=#d27b53;;false;true
 keyword_4=#f99157;;false;true

-identifier=#66cccc;;true;false
+identifier=#d3d0c8;;false;false
 # Person.rb = ActiveModel::Conversion
 identifier_1=#ffcc66;;true;false
-identifier_2=#66cccc;;true;false
+identifier_2=#66cccc;;false;false
 identifier_3=#6699cc;;true;false
 identifier_4=#cc99cc;;false;false

@@ -101,7 +102,7 @@
 # PHP = $_GET
 preprocessor=#6699cc
 regex=number_1
-operator=#d3d0c8;;true;false
+operator=#66cccc;;false;false
 decorator=#6699cc;;false;false
 other=#f2777a

Now the .R code looks much more readable under the tweaked base16 theme:

And very similar to the RStudio (Ace) implementation of the Tomorrow theme:

Should I come up with a pull request implementing these changes upstream (in https://github.com/chriskempson/base16-builder )?

[RobLoach]

Good find, I haven't tried this in a while. The templates are available here: https://github.com/chriskempson/base16-builder/tree/master/templates/geany

[landroni]

Thanks. I think I can fix the templates, but do you agree with the proposed changes (in principle, i.e. removing most of the bold/italic formatting)?

[RobLoach]

Most definitely. I found it bolded way too aggressively myself. :+1:

[landroni]

I've now pushed a commit on my fork of base16-builder: https://github.com/landroni/base16-builder/commit/c3120afa57dbdb9ef0c1abe2ca477aba9f8f4b52

I've only modified what affects R files, and didn't check other file types. Just a note: for the 'light' template I didn't switch the ["0C"] and ["05"] colors since it seemed to me that this made the themes positively unreadable.

Before I make a Pull Request, could you take a look a the tweaked themes to see that nothing obvious was broken?

[RobLoach]

Looks fantastic! Updated this repository with what's given at output/geany. I've added you as a collaborator on this repository too, if you want to update it if you have any going forwards. :+1:

[RobLoach]

@landroni Actually, going to keep this open until it's in base16-builder. Mind opening that PR? Thanks!

[landroni]

Absolutely! I'll go ahead with the PR.

[landroni]

I went ahead with the PR upstream.

[RobLoach]

Thanks so much, it looks great!