search

RobLoach / base16-geany

:crystal_ball: Base16 Scheme for Geany
https://github.com/chriskempson/base16
Other
40 stars 13 forks source link

adjust color for brace_good in dark themes #7

Closed landroni closed 9 years ago

landroni commented 9 years ago

I would like to propose changing the color for brace_good in https://github.com/chriskempson/base16-builder/blob/master/templates/geany/dark.conf.erb from base0B to base0A.

So https://github.com/chriskempson/base16-builder/blob/master/templates/geany/dark.conf.erb#L39 would now look like: 

brace_good=#<%= @base["0A"]["hex"] %>;;true;false

The reason for this change is that in my experience (mostly using Base16 Eighties Dark) has a insufficient contrast for the braces. It's really, really hard to spot them when working with code. In comparison, base0A allows for much easier spotting and following of braces. I've been using this for several months, and find it much better overall. I've tested this color change with other dark themes, and it doesn't seem to break anything in particular.

Any objections to proposing such a PR upstream?

RobLoach commented 9 years ago

:+1:

landroni commented 9 years ago

Merged upstream.