Open davidvanlaatum opened 8 years ago
when you say "Does not work" could you be more specific?
The zikula project is also having some issues with component-installer but I cannot tell if the problems are the same as this. One odd thing for us is that it appears to work for me locally (MacOS) but not at our CI build server.
What error do you receive? Or are they just deprecated notices?
I am not receiving any errors at all. We are simply just not getting our assets installed as we did a few days ago. see https://github.com/zikula/core/issues/2649
the output of our CI build can be seen here where there does not seem to be any errors related to the component-installer or asset installation.
I just upgraded the composer version on our server before that build, so it is using the most recent build of composer.
here is the output of a build that worked correctly.
comparing these two output files, I see that
ComponentInstaller\Installer::postAutoloadDump
is not run in the second. it appears twice in the working build:
Writing lock file Generating autoload files ComponentInstaller\Installer::postAutoloadDump Compiling component files
zikula > prepare:
[echo] Prepare...
Loading composer repositories with package information Installing dependencies from lock file Nothing to install or update Generating autoload files ComponentInstaller\Installer::postAutoloadDump Compiling component files
zikula > build:
I think this might be the problem: https://github.com/composer/composer/commit/c0b49d09f300dde5f88a4bea19a9d32806de6886
so I was able to reproduce the problem we are having at our ci server by doing the following locally:
> composer install --prefer-dist --no-dev --no-scripts --ignore-platform-reqs
...
> php src/app/console assets:install src/web
so apparently, my problem is the second (Symfony's assets:install
command) is not running the component-installer scripts.
now, I am not sure about my previous statement. In the working builds, the Generating autoload files
triggers this:
> ComponentInstaller\Installer::postAutoloadDump
Compiling component files
but in the builds that do not, it is not triggered.
Is it possible that component-installer did not respect the --no-scripts
command previously and that this was changed a couple days ago? or composer itself changed that behavior?
@davidvanlaatum - sorry to have taken over your ticket. :8ball:
I think my issue was due to https://github.com/composer/composer/issues/4626
Component folder is empty after install with alpha11
composer/composer#4627 seems to have fixed it for me. Working as before on Composer version 1.0-dev (fbab2bfa173e1bf3667051b99bf544cccad1ad9d) 2015-11-23 15:12:33
yes it does appear to have fixed for me to
1.0.0-alpha10 listed and I assume this has been removed in 11: Break: The following event classes are deprecated and you should update your script handlers to use the new ones in type hints: Composer\Script\CommandEvent is deprecated, use Composer\Script\Event Composer\Script\PackageEvent is deprecated, use Composer\Installer\PackageEvent