RobLoach / component-installer

Install Web Components through Composer
https://asset-packagist.org/
Other
280 stars 35 forks source link

Open up Process loading and added configuration. #96

Closed InconclusiveImpurity closed 8 years ago

InconclusiveImpurity commented 8 years ago

Processes used to be immutable and without an additional fork Users could not modify or create their own processes. This commit allows to define any Process currently available to be used and configure Process behavior by using the options of said Process.

This change is fully backwards compatible. No contract is changed. Right now no additional configuration has been added.

Signed-off-by: Thomas Vogt thomas.vogt@tuta.io

InconclusiveImpurity commented 8 years ago

I'll have a look at the given Tests later and fix the integration tests.

InconclusiveImpurity commented 8 years ago

All test pass. See travis-ci/travis-ci#1385 for further information.

I would recommend deleting 5.3.3 out of the environment scope, since 5.3 and 5.4 pass.

RobLoach commented 8 years ago

Looks great! Thanks a lot. I'll update travis.yml after merge.

InconclusiveImpurity commented 8 years ago

Thanks! You might consider closing a few issues now, since this Features makes some issues irrelevant / configurable. E.g. #93

I'll add a short documentation once i have more time to do so, but anyone may to so on their own. It's not a complicated feature. The foundation was already within the great software itself. This Software does exactly what i was looking for (Without any complicated steps). Keep up the good work!