RobLoach / docker-composer

:ok_woman: Docker container to install and run Composer.
https://hub.docker.com/r/library/composer/
Other
104 stars 49 forks source link

Make an official composer Docker container #40

Open RobLoach opened 8 years ago

RobLoach commented 8 years ago

Would be nice to have this as one of the "official" repositories available in Docker....

zoidyzoidzoid commented 8 years ago

This would be really awesome as part of the official library.

Could we also do PHP 7 versions before we add it to the official library?

(I see they're there, I just missed them in the readme, my bad.)

alcohol commented 8 years ago

I am rather surprised you dare call any of this "official", considering you did not even reach out to us and blatantly registered our name as your organization and use our logo for it.

RobLoach commented 8 years ago

@alcohol I've spoken with Seldaek about this, he found it best to keep the Docker container off the GitHub /composer org. By "official", what I mean have the repository live in the /docker-library org so that you use it as composer rather then composer/composer.

Is there anything you'd like to see improved? Would you like repo write access?

alcohol commented 8 years ago

This is your project, so I'm not going to ask you to move it to our Github organization. I know Seldaek prefers not to endorse third party tools/components when he is not involved with them himself. I personally am quite fond of Docker though, and would like to contribute or be involved, if possible.

I am simply a bit baffled by the fact that you registered the composer organization on the docker hub, rather than simply asking us to proxy it for you.

I can imagine that releasing it under the composer namespace is a lot more attractive than releasing it under your personal namespace, but it is a somewhat questionable move.

RobLoach commented 8 years ago

This is your project, so I'm not going to ask you to move it to our Github organization.

I actually asked Seldaek to move it to /composer a while ago, and he said no.

I am simply a bit baffled by the fact that you registered the composer organization on the docker hub, rather than simply asking us to proxy it for you.

I added the Composer maintainers of who I found had Docker Hub accounts. There was lots of transparency behind it, across both IRC, and the issue queue. The project is almost two years old at this point, and its has been growing. Contributions from others like alpine support and supporting both PHP 5/7 helped keep it alive. I'd like for it to grow even further, if you have any ideas on a direction, feel free to propose them.

I've added you to both the GitHub and the Hub org. Would love your thoughts on how it could improve.

alcohol commented 8 years ago

Cheers for the invitation. I do not recognize any of the other "owners" of the docker organization though, so I'm not sure who you added.

I'll have a closer look at my earliest convenience. The only possible addition/improvement I can think of from the top of my mind right now, is to create images based on Git tags, to provide a containerized counterpart for each version that is also offered at https://getcomposer.org/download/

alcohol commented 8 years ago

For the alpine based Dockerfile you could consider using --no-cache instead of --update (read more).

alcohol commented 8 years ago

I have some (possibly radical) changes to suggest and various other things I would like to discuss. Can I reach you on a medium that is a bit more direct than the Github issue tracker? E.g. Twitter DM, IRC, or some Slack channel?

sylus commented 8 years ago

Some slack channel would be great so other collaborators who use this and / or extend from this image can also be in the loop.

alcohol commented 8 years ago

We could also use Gitter to keep it simple.

alcohol commented 8 years ago

https://gitter.im/composer/docker