RobLoach / libretro-database-scummvm

ScummVM.dat file to run ScummVM games in RetroArch
http://github.com/libretro/scummvm
14 stars 9 forks source link

Added my italian games (they use different "Scummvm id" so they have different CRC) #5

Closed lollo78 closed 5 years ago

lollo78 commented 8 years ago

To test my commits I compiled the RDB and scanned all my games. Works like a charm! Thank you RobLoach for all your hard work. :+1:

RobLoach commented 8 years ago

We'll have to update this to build in the .js file rather then updating the DAT itself. I think the way to do this would be to....

  1. Introduce a languages.json

    {
       "it": "italian"
    }
  2. Have it loop through each language and append -${lang} to each filename and content.
  3. Rebuild the dat and games with the new stuffs.
lollo78 commented 8 years ago

Ehm... I don't think that I understand :D

lollo78 commented 8 years ago

If I can help you, don't hesitate to ask ;)

RobLoach commented 8 years ago

@lollo78 Just added language support in there. The ones with CD or VGA arn't in there. You may just have to edit the ID of those manually in the ScummVM interface in order to have them.

Unless you can think of a easy way to add VGA/CD support automatically to them all.

lollo78 commented 8 years ago

support.json

{
    "cd": "cd"
}

video.json

{
    "vga": "vga"
}

?!? lol, I don't know ;)

@kivutar?

RobLoach commented 8 years ago

Adding cd and vga explicitly is an option, but then we'd end up with way too many game codes. Just informing people to fix up the ID may be the easiest. Just remove "vga" or "cd" from those in ScummVM UI.

lollo78 commented 8 years ago

IMHO, from an user side, ScummVm is not simple like the other libretro cores. I don't think all of them know how to remove "vga" and "cd" from ScummVM UI (or manually from the ScummVM.ini). Integrate this cases in your script will help a lot and will contribute to use Retroarch also for level users

RobLoach commented 8 years ago

@lollo78 See the latest changes in ScummVM.dat? Makes it so that you don't need the .scummvm files anymore. You can find the change in the ScummVM core for how it was accomplished.

lollo78 commented 8 years ago

Hi dear! I just returned from two weeks vacation. I'll try it as soon as possible. Thanks a lot

inactive123 commented 7 years ago

Do you guys still want to patch this up so it can be merged?

RobLoach commented 7 years ago

Not entirely sure this works as expected. ScummVMs launching system is really weird, and --auto-detect will fix most of it.

Rather hold off, and seeing if the CLI launch fixes help us.