RobLoach / net.lutris.Lutris

Pull requests for new applications to be added
https://flathub.org
2 stars 0 forks source link

Add wine dependencies #15

Open gasinvein opened 5 years ago

gasinvein commented 5 years ago

Lutris provides its own wine build. We need to make sure they work fine.

RobLoach commented 5 years ago

You get this dialog box when Lutris cannot find Wine...

Screenshot at 2019-03-30 07-24-46

Games still are playable with the Wine runtimes downloaded through Lutris, however. May need clarification from @strycore whether or not its still needed on the system.

gasinvein commented 5 years ago

Adding wine with its dependencies is not a problem. The problem is building both 32-bit and 64-bit variants for a single app, it has already popped up for other flatpak app, e.g. https://github.com/flathub/com.valvesoftware.Steam/issues/78#issuecomment-417260505

tannisroot commented 5 years ago

IIRC Lutris needs all hard and optional dependencies of wine plus some additional stuff for Origin and Battle.net (you can find them on these pages: https://github.com/lutris/lutris/wiki/Game:-The-Sims-2 https://github.com/lutris/lutris/wiki/Game:-Blizzard-App https://github.com/lutris/lutris/wiki/Wine-Dependencies , both 32 and 64 bit are needed). Also, some games might need base, good, bad and ugly gstreamer plugins, again both 32 and 64 bit variants. Wine itself is not needed and that check in the client was done to ensure users have those dependencies installed in perhaps a bit lazy way. Upstream might need to add some kind of launch argument to allow Flatpak to disable this check.

shuriken1812 commented 5 years ago

@tannisroot the optional dependencies like for example sqlite for battle net as an example, we have to add these optional dependencies to flatpak. But in future we have to keep updating these deps then if more optional dependencies arrive for other applications in the future..

gasinvein commented 5 years ago

I just tried this and gotta say it works pretty well: installed wine steam and it runs nicely. Tried installing Path of exile game and it's done. Sadly I can't run it because it requires libgcrypt:

0153:err:module:load_builtin_dll failed to load .so lib for builtin L"WLDAP32.dll": libgcrypt.so.11: cannot open shared object file: No such file or directory

Just looked at the comments above and @AsciiWolf reported something similar: does this mean that the library needs to be included in the flatpak manifest or should lutris handle this?

Originally posted by @TomasTomecek in https://github.com/flathub/flathub/pull/926#issuecomment-481395642

shuriken1812 commented 5 years ago

Like this there will be games which require extra dependencies, that will be a problem in flatpaks, not exactly a problems but ofcourse people will have to wait for the dependency to be added in the flatpak 🤔

Whats my recommendation is to give flatpak commands on game specific pages like lutris have for origin battle net to install flatpak dependency in the same path or user. Like we have terminal commands given for fedora on battlenet sudo dnf install sqlite and other distros.. We can include flatpak commands on the pages..