search

RobLoach / net.lutris.Lutris

Pull requests for new applications to be added
https://flathub.org
2 stars 0 forks source link

Add udev #36

Closed RobLoach closed 5 years ago

RobLoach commented 5 years ago

References #34

@gasinvein I had closed the PR because it didn't compile before. I've now moved the module into libusb, and re-enabled udev. Seems to compile fine now.

gasinvein commented 5 years ago

Did you check if libusb really picks up this libudev? AFAIR newer libusb requires udev >= 196 or so, which is part of systemd.

RobLoach commented 5 years ago

I didn't check if libusb really picks it up. Is there a way to do that?

gasinvein commented 5 years ago

Well, you can look at configure output which should print something like "found udev" or use ldd to see if the built libusb library is linked with libudev.

Anyway, if the whole thing builds fine, merging it shouldn't break anyting.

gasinvein commented 5 years ago

shared-modules probably needs to be updated to include flathub/shared-modules#58

RobLoach commented 5 years ago

Good calll.... Also cleans up the diff.

gasinvein commented 5 years ago

LGTM, merging.