search

RobLoach / net.lutris.Lutris

Pull requests for new applications to be added
https://flathub.org
2 stars 0 forks source link

Explicitly add ld path for .Compat.i386 extension #39

Closed gasinvein closed 5 years ago

gasinvein commented 5 years ago

See https://github.com/flathub/flathub/pull/926#issuecomment-489156990

gasinvein commented 5 years ago

@valentindavid is this ok?

valentindavid commented 5 years ago

This seems fine. In Steam there was also first line:

include /run/flatpak/ld.so.conf.d/app-*-org.freedesktop.Platform.GL32.*.conf

I do not remember exactly what case it was for, but I think this is important when using GL extensions, like mesa-git, or some provided by the operating system. I do not think nvidia needs that. We can try without it. And if there is some issue we can put it as well later.

gasinvein commented 5 years ago

Maybe adding add-ld-path: . to the extension definition (instead of ld.so.conf file) would be better?

valentindavid commented 5 years ago

There was issue with priority. So we had to make the app add it manually. Unfortunately. Supporting i386 was a bit special, so we decided against making the logic behind extensions in flatpak more complicated.