search

RobLoach / node-raylib

Node.js bindings for Raylib
https://robloach.github.io/node-raylib/
Other
245 stars 20 forks source link

use cmake instead of submodule #101

Closed konsumer closed 2 years ago

konsumer commented 2 years ago

This addresses build issues like #97 and #98 on windows, mac, and linux. Basically it uses a git-clone that cmake manages to build, instead of relying on system-wide libraries or a submodule. This means lighter npm, it's easier to deal with in instructions (no submodule stuff or--recursive` clone) and it drops the check for the system-wide raylib (which seems broken, at least on mac/linux.)

konsumer commented 2 years ago

I would additionally recommend changing cmake-js compile to cmake-js build in postinstall. We found on the other branch it cut down on trying to download stuff redundantly, which greatly speeds up dev builds, and otherwise seemed to work about the same.