RobLoach / raylib-nuklear

Nuklear immediate mode GUI for raylib
https://robloach.github.io/raylib-nuklear/
zlib License
141 stars 19 forks source link

Use DrawRectangleRoundedLinesEx and update nuklear #66

Closed aschuhardt closed 4 months ago

aschuhardt commented 4 months ago

As of https://github.com/raysan5/raylib/commit/b51f4db8c29eba3506e953b351bedbf41f2a5c95 the method signature of DrawRectangleRoundedLines has changed. The method with the added Ex suffix has the old signature.

aschuhardt commented 4 months ago

Good idea, I'll add that shortly.

On May 22, 2024 12:42:12 PM UTC, Rob Loach @.***> wrote:

@RobLoach requested changes on this pull request.

@@ -448,7 +448,7 @@ DrawNuklear(struct nk_context ctx) rect.y += ((float) r->line_thickness) scale + 1.0; rect.width = NK_MAX(rect.width - (2 ((float) r->line_thickness) scale + 1.0), 0.0); rect.height = NK_MAX(rect.height - (2 ((float) r->line_thickness) scale + 1.0), 0.0);

  • DrawRectangleRoundedLines(rect, roundness, RAYLIB_NUKLEAR_DEFAULT_ARC_SEGMENTS, (float)r->line_thickness * scale, color);
  • DrawRectangleRoundedLinesEx(rect, roundness, RAYLIB_NUKLEAR_DEFAULT_ARC_SEGMENTS, (float)r->line_thickness * scale, color);

Thanks a lot! Since this change is in raylib master and not yet in a stable release, mind if we put some RAYLIB_VERSION checks in there for it so we keep backwards compatibility?

-- Reply to this email directly or view it on GitHub: https://github.com/RobLoach/raylib-nuklear/pull/66#pullrequestreview-2071077315 You are receiving this because you authored the thread.

Message ID: @.***>

RobLoach commented 4 months ago

Thanks! Looks great.