RobPo / Paperino

E-Paper display library for the Particle & Arduino family.
https://robpo.github.io/Paperino/
BSD 3-Clause "New" or "Revised" License
37 stars 6 forks source link

Use SPIsettings() to allow SPI slaves with different SPI settings #4

Closed RobPo closed 7 years ago

RobPo commented 7 years ago

SPIsettings() is available since firmware 0.6.1 - it allows usage of SPI slaves with different bus settings. Furthermore we could save three lines of code ;-) - Please implement

JohnnyKaramello commented 7 years ago

maybe keep both version in the examples and put the corresponding firmware version as a comment e.g.

SPIsetting(...) //for firmware version 0.61 //SPI1.begin() //for firmware version 0.5.x

RobPo commented 7 years ago

Ok I'd like to keep the code clean and as short as possible (to lower the barriers): Since Particle makes it easy to upgrade to the latest firmware version (which should be done anyway), I will add a comment in comment-section so everybody should be aware of the minimum required firmware release.

RobPo commented 7 years ago

Implemented in last release