search

RobRendell / gTove

A simple virtual gaming tabletop webapp in 3D, using Google Drive as the backing store.
MIT License
58 stars 14 forks source link

Add fit-to-page for pdf #28

Closed andykuo1 closed 3 years ago

andykuo1 commented 3 years ago

Adds a "Fit Selection to Page" button for pdf crop adjustments.

RobRendell commented 3 years ago

Conversation on Discord:

RobRendell — Today at 13:52 The "fit to page" item in the TODO list was actually to fit the PDF page to the browser page, rather than adjusting the crop rectangle to fit the entire PDF page. Like in a PDF reader, you can adjust the zoom of the page relative to your window, and one of the options is "fit to page" andykuo1 — Today at 13:56 And i see. sorry about that :stuck_out_tongue: that makes sense. RobRendell — Today at 13:56 Do you think a button to select the whole page would be useful anyway? Perhaps if you wanted to put down an image with rules text on it or something... andykuo1 — Today at 13:57 well i was just trying to get familiar with the project, so was just picking stuff up to do. as for whether it'd be useful... i think it would be better as an intuitive resize to just snap to edge instead of a dedicated button