search

RobThree / NGeoNames

Inspired by https://github.com/AReallyGoodName/OfflineReverseGeocode
MIT License
88 stars 22 forks source link

Add support for AlternateNamesV2 #7

Closed rodoch closed 6 years ago

rodoch commented 6 years ago

This PR adds support for the AlternateNamesV2 file type (see #5). It really just adds two new fields to the AlternateName entity that existed already - To and From, denoting the start and end of the historical period during which a particular alternate name was in usage. These fields have a type of String - I wasn't sure if this was the most appropriate type (versus DateTime, for example) but there seem to be a good few edge cases in the data itself (see, for example, alternate name ID 13653649). Tests and some new test data are included.

RobThree commented 6 years ago

Hi! Thanks very much! I'll have a look at this ASAP and merge it. From a first glance it looks great!