RobThree / SimpleFeedReader

Easy to use, simple, Syndication feed reader
MIT License
32 stars 11 forks source link

PCL support? #3

Open gc435 opened 9 years ago

gc435 commented 9 years ago

Does this work with PCLs, specifically PCL profile 78? That's the default profile used by Xamarin.Forms apps.

I can add it via Nuget with no errors, but I don't think it worked. I can't add a using statement for it, and can't find the FeedReader() constructor.

ghuntley commented 8 years ago

FYI when using Profile111, when installing into a PCL library this package is not automatically added as a reference. Additionally Documentation.chm is incorrectly added to the project.

PM> Install-Package SimpleFeedReader
Attempting to gather dependencies information for package 'SimpleFeedReader.1.0.4' with respect to project 'ReactiveReader.Core', targeting '.NETPortable,Version=v4.5,Profile=Profile111'
Attempting to resolve dependencies for package 'SimpleFeedReader.1.0.4' with DependencyBehavior 'Lowest'
Resolving actions to install package 'SimpleFeedReader.1.0.4'
Resolved actions to install package 'SimpleFeedReader.1.0.4'
Adding package 'SimpleFeedReader.1.0.4' to folder 'D:\Dropbox\oss\rxui-samples\ReactiveReader\packages'
Added package 'SimpleFeedReader.1.0.4' to folder 'D:\Dropbox\oss\rxui-samples\ReactiveReader\packages'
Added package 'SimpleFeedReader.1.0.4' to 'packages.config'
Successfully installed 'SimpleFeedReader 1.0.4' to ReactiveReader.Core
RobThree commented 8 years ago

I have never used Xamarin nor any idea how these "PCL profiles" work (or should work). I understand from @ghuntley's post that the reference is missing? Does it work when it's added manually?

Why is documentation.chm added "incorrectly"? For Windows/VisualStudio that's intended behaviour (though I do consider no longer adding it to the solution, leaving it in the '/packages' directory for reference).

ghuntley commented 8 years ago

Hey Rob,

re: xamarin

Free for open-source developers, like you if you fill in this form and link back to this issue/project.

https://resources.xamarin.com/open-source-contributor.html

When filling it out and ask for iOS, Android and Mac licenses.

re: documentation.chm

I'd recommend removing it from the solution and putting it (and the source code used to build) in /packages

re: pcl

Have a read of this which explains PCL's:

https://oren.codes/2015/06/16/demystifying-pcls-net-core-dnx-and-uwp-redux/

The numbers represent target, right now you target net40-client.

https://github.com/RobThree/SimpleFeedReader/blob/master/SimpleFeedReader.nuspec#L24-L25

Here's an example of my library which targets Profile111, Profile259 and Profile78 (which is what you want evolve towards)

https://github.com/ghuntley/conditions/blob/master/nuget/Conditions.nuspec#L22-L23

re: migrating to pcl

You should be able to get away just updating the nuspec but if you want to do it properly and learn what they are all about:

:beers:

RobThree commented 4 years ago

Not sure but does #11 help?