RobThree / SimpleFeedReader

Easy to use, simple, Syndication feed reader
MIT License
32 stars 11 forks source link

Package not registering #9

Closed younkin427 closed 4 years ago

younkin427 commented 7 years ago

screen shot 2017-10-01 at 4 39 17 pm Xamarin is not registering SimpleFeedReader. Is there any way this can be fixed?

Dids commented 7 years ago

Seeing the same thing here. It's probably not strictly Xamarin-related, but more likely something wrong with the NuGet package itself.

Dids commented 7 years ago

Figured out a workaround.

The issue is that the package (the DLL) isn't getting referenced automatically, which it definitely should.

You can manually edit references, then browser to packages/SimpleReader and select the DLL, after which it should start working again.

RobThree commented 7 years ago

I’m currently not in a position to fix this (hospitalized; nothing too bad though). Will have a look at this as soon as I can. PR’s are welcome.

RobThree commented 7 years ago

Sorry didn’t mean to close... 😬

Dids commented 7 years ago

Update: simply adding a reference manually isn't enough, as it looks like it's still not getting included in the compiled app:

Could not load type of field 'SimpleFeedReader.DefaultFeedItemNormalizer:CS$<>9__CachedAnonymousMethodDelegate2' (3) due to: Could not resolve type with token 01000019 (from typeref, class/assembly System.ServiceModel.Syndication.SyndicationLink, System.ServiceModel, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089) assembly:System.ServiceModel, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 type:System.ServiceModel.Syndication.SyndicationLink member:<none>
Dids commented 7 years ago

@RobThree No worries, get better soon! I'll see if I can whip up a quick PR in the mean time.

Dids commented 7 years ago

Not sure I have the time, unfortunately, as this would most likely need to be migrated to .NET Standard (2.0), which would also mean switching to the new .NET Standard compatible syndication feed reader/write, available here: https://github.com/dotnet/SyndicationFeedReaderWriter

RobThree commented 4 years ago

See #11