Closed Beanow closed 2 years ago
We could even put this behind a #if defined (AGS02MA_READ_REGISTERS)
or similar, so extra code isn't included for normal use at all.
You need to merge the new master into this branche.
Things have been updated. Not entirely sure how long for (auto address : addresses)
has been present in compilers arduino uses, but the CI seems to build anyway. And it's in the example rather than library itself. :shrug:
@beanow
Not entirely sure how long for (auto address : addresses) has been present in compilers arduino uses
What you can do is uncomment all platforms in the .arduino-ci.yml that would let the build CI at least test all supported platforms. That would be max you can test, if the test not fails you can roll back to minimize the build CI effort.
oops wrong button 😎
@Beanow
Not entirely sure how long for (auto address : addresses) has been present in compilers arduino uses
What you can do is uncomment all platforms in the .arduino-ci.yml that would let the build CI at least test all supported platforms. That would be max you can test, if the test not fails you can roll back to minimize the build CI effort.
I don't think that'll add much insight. It's compiler support, not board support I was thinking about. Looked it up and I think we're fine.
auto
type keyword and for (x : y)
"range based for statements" are part of the C++11 standard.
Which is allegedly available by default from v1.6.6 of the Arduino IDE.
https://www.arduino.cc/en/software/ReleaseNotes#arduino-166---20151103 released 2015.
For an example sketch, 2015 seems plenty compatible to me.
lgtm, going to merge into master
In a somewhat similar way to the proposed calibration feature, here's an idea for a minimal register dumping function. If you're not using this, it only adds a small amount of code to the actual library, offloading all speculative interpretation of register data to the example sketch.
Sample output: