search

RobTillaart / CRC

CRC library for Arduino
MIT License
79 stars 17 forks source link

Discuss 1.0.0 #35

Closed RobTillaart closed 1 year ago

RobTillaart commented 1 year ago

@vovagorodok

Squashed and Merged your branch into master, so other people can download the new version. Will release it asap.

Created this issue to discuss the 1.0.0 version further.

update:

vovagorodok commented 1 year ago

Great news! I'll celebrate it by additional cup of coffee :D Let's wait for feedback from community

According to comments headers. Do you mean legal information? I think that it only generates additional unused text. But perhaps it's only my preference

RobTillaart commented 1 year ago

It is unused text, but compilers skip those lines fast and for me it is informative. In the .h files the lines are after #pragma once so the compiler does not even parse them.

RobTillaart commented 1 year ago

Great news! I'll celebrate it by additional cup of coffee :D

You deserve it as it was quite some work!

vovagorodok commented 1 year ago

One additional topic i think. Was copy pasted .._REF_IN and .._REF_OUT. Hmm, why REF but not REV (like reverse)?

RobTillaart commented 1 year ago

One additional topic i think. Was copy pasted .._REF_IN and .._REF_OUT. Hmm, why REF but not REV (like reverse)?

replaced in develop branch, build runs.

RobTillaart commented 1 year ago

No new topics popped up in 4 weeks so I close this issue