RobTillaart / CRC

CRC library for Arduino
MIT License
79 stars 17 forks source link

warning: 'deprecated' attribute directive ignored [-Wattributes] #37

Closed Teddyz closed 10 months ago

Teddyz commented 1 year ago

Hello, I get a lot of these warnings when using version1.0.x I upgraded Arduino to 2.11 and they are still shown when compiling. I need to have warnings shown to keep my own code in decent shape :)

d:\Mina Dokument\Arduino\libraries\CRC\src/CRC.h:114:48: warning: 'deprecated' attribute directive ignored [-Wattributes] crc_size_t yieldPeriod = CRC_YIELD_DISABLED);

RobTillaart commented 1 year ago

@Teddyz With the step to 1.0.0 the library had a serious refactor . This caused a breaking change in several functions,. The old interface was kept with warnings so the "old" code would still work with a warning.

So you need to replace your calls to CRC with the new API calls and then the warnings should disappear.

RobTillaart commented 1 year ago

If I understand correctly you use calls to crc32 Please try calcCRC32() calls.

RobTillaart commented 1 year ago

@Teddyz Is the problem solved now?

Teddyz commented 1 year ago

Sorry, I have not looked further at this yet.

It looks to me that the warning I see is for every deprecated in your code, not for the old command I use. I have another warning for some other old command and that looks ok.

I will come back with better info, you can close this if insufficient info is is provided.

RobTillaart commented 1 year ago

OK, You can always post a minimal sketch that shows the messages so I can try to recreate the issue at hand,

RobTillaart commented 10 months ago

As there is no more new info for two months I close this issue. Feel free to reopen when new information is available.