Fix CRC16::_update - Githubissues

RobTillaart / CRC

CRC library for Arduino

MIT License

81 stars 17 forks source link

Fix CRC16::_update #4

Closed manchoz closed 3 years ago

manchoz commented 3 years ago

This PR fixes an issue in the CRC16::_update method where a uint16_t reverse(uint16_t) function is used instead of the correct uint8_t reverse(uint8_t).

Copied a _reverse8() method from CRC.h.

RobTillaart commented 3 years ago

Good find! - seems that the same error is in the CRC32 and CRC64 classes too.

The classes are not (unit) tested so there is some work todo here.

RobTillaart commented 3 years ago

Working on it...

fix and unit test merged...

thanks again for finding!

manchoz commented 3 years ago

@RobTillaart Thank you so much! Nice library, indeed.

RobTillaart commented 3 years ago

Have to fix keywords.txt and then it is ready for new release.

RobTillaart commented 3 years ago

0.1.2 released