search

RobTillaart / DHTNew

Arduino library for DHT11 and DHT22 with automatic sensor recognition
MIT License
96 stars 15 forks source link

setTempOffset and setHumOffset #74

Closed us292231 closed 2 years ago

us292231 commented 2 years ago

It looks like the header has definitions for setTempOffset/getTempOffset and setHumOffset/getHumOffset and the class has the variables, but it doesn't seem that the implementation is missing.

us292231 commented 2 years ago

Ok, I'm an idiot. I see it now...

RobTillaart commented 2 years ago

Q: do I need to improve documentation, comments or readme.md ?

us292231 commented 2 years ago

Hi,

Your code and documentation are really nice, no improvements needed. Also, a big thank you for putting it out there, it has really helped me. Your efforts are very much appreciated.

I made a really bad mistake and jumped to a conclusion that was wrong. I forgot to connect the dots in my code and didn't catch that until just after I clicked save... Totally my bad in multiple ways.

Thanks for asking, Jim

From: Rob Tillaart @.> Sent: Tuesday, March 1, 2022 1:04 AM To: RobTillaart/DHTNew @.> Cc: Jim Christenson @.>; State change @.> Subject: Re: [RobTillaart/DHTNew] setTempOffset and setHumOffset (Issue #74)

Q: do I need to improve documentation, comments or readme.md ?

— Reply to this email directly, view it on GitHubhttps://github.com/RobTillaart/DHTNew/issues/74#issuecomment-1055093347, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACG3FHJYN4WHC356T7W7ZJ3U5W6RJANCNFSM5PSL4L7A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you modified the open/close state.Message ID: @.***>