search

RobTillaart / MCP4725

Arduino library for 12 bit I2C DAC - MCP4725
MIT License
24 stars 7 forks source link

Buffer overflow in the example code #25

Closed toxygen closed 1 year ago

toxygen commented 1 year ago

This part of example code is overflowing the array:

https://github.com/RobTillaart/MCP4725/blob/cdfd21205f6693be082c27798d49769cfc468545/examples/MCP4725_wave_generator/MCP4725_wave_generator.ino#L44

array defined here [0..359]: https://github.com/RobTillaart/MCP4725/blob/cdfd21205f6693be082c27798d49769cfc468545/examples/MCP4725_wave_generator/MCP4725_wave_generator.ino#L36

RobTillaart commented 1 year ago

Thanks for reporting this issue. Will look into it asap.

RobTillaart commented 1 year ago

Created develop branch with fix + minor edits

RobTillaart commented 1 year ago

Created Pull Request, build started

RobTillaart commented 1 year ago

Build successful, merged, release 0.3.6

RobTillaart commented 1 year ago

Thanks for reporting, appreciated