search

RobTillaart / MS5611

Arduino library for MS5611 temperature and pressure sensor
MIT License
17 stars 5 forks source link

Updated oversampling, minor edits to reflect changes, minor edits to examples #13

Closed LyricPants66133 closed 2 years ago

LyricPants66133 commented 2 years ago

Added set and get functions for oversampling, using 5 different word options to reflect a different amount of time. I updated keywords.txt and readme to reflect these changes. I also made minor edits to the examples, and added a short explanation of the available oversampling settings. I also tested the library with my sensor, and it works very well.

RobTillaart commented 2 years ago

Thanks for the PR, I will try to look into it tomorrow in more depth. (busy upgrading / cleaning all my libs for open commits so it might take some time"

RobTillaart commented 2 years ago

quick first look seems good!, maybe create a specific example to show the working?

RobTillaart commented 2 years ago

title of issue => exmaples ?

RobTillaart commented 2 years ago

@LyricPants66133 Typical math for oversampling is 4x as much samples gives 1 bit accuracy extra. More info - https://en.wikipedia.org/wiki/Oversampling#Resolution

RobTillaart commented 2 years ago

to be continued ....

RobTillaart commented 2 years ago

@LyricPants66133 released 0.3.2 I fixed backwards compatibility, while keeping the functionality you proposed. renamed the internal variabele name to sampleRate, added some more examples

Can you please verify it still works for you? Thanks.